Skip to content

Fixes corner case for comparing nested overloads #9259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 5, 2020
Merged

Fixes corner case for comparing nested overloads #9259

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ecf5d82
Fixes our very own case for comparing nested overloads
sobolevn Aug 4, 2020
218ee5d
Update subtypes.py
sobolevn Aug 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions mypy/subtypes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,6 +399,12 @@ def visit_overloaded(self, left: Overloaded) -> bool:
return True
return False
elif isinstance(right, Overloaded):
if left == self.right:
# When it is the same overload, then the types are equal.
# This was originally introduced as a fix / hack for:
# https://github.com/python/mypy/issues/9147
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to add a comment in the source referring to the bug (people can find that information using git blame).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

return True

# Ensure each overload in the right side (the supertype) is accounted for.
previous_match_left_index = -1
matched_overloads = set()
Expand Down