Fix generic inheritance for attrs init methods #9383
Conversation
natemcmaster
force-pushed
the
attr-generic
branch
from
54dc7f5 to
5619bfa
Compare
|
It seems CI is currently broken on this project. The errors in windows builds appear to be a problem with the C++ toolchain, and on Travis, something is broken with setuptools. Not sure how to resolve those errors as they appear unrelated to my proposed changes. |
|
Maybe this message on python-dev provides a clue? https://mail.python.org/archives/list/[email protected]/message/TJE5XWLKRC3EQUXKSHCJNA25H3WGVP5B/ |
|
Looks like pypa/setuptools#2350 (or similar), I'll try to submit a PR using the env var workaround. |
|
CI is passing now on this PR. :) |
|
Friendly bump for review :) |
|
Hello there, checking in again. I merged from master and pushed to my branch to ensure this PR is still merge-conflict free and passing tests. Any chance I can get a review? Thanks! |
|
Thank you again! :-) |
Description
Fixes #5744
Updates the attrs plugin. Instead of directly copying attribute type along the MRO, this first resolves typevar in the context of the subtype.
Test Plan
Added 4 new test cases to cover various generic inheritance scenarios.