Recognize -stubs directories as valid package directories #9445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvanrossum
reviewed
Sep 15, 2020
Co-authored-by: Guido van Rossum <[email protected]>
gvanrossum
approved these changes
Sep 16, 2020
|
Is there any way this can be included in 0.790? |
|
I very much doubt it -- according to #9290, the release branch was cut quite a while ago, and cherry-picking must be minimized so as not to invalidate the extensive testing that has already been applied to the release branch. |
|
@gvanrossum makes sense. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, running
mypy typedpkg-stubs(or any sub-file contained in the directory) in a project similar to https://github.com/ethanhs/stub-package results in an error:This PR allows directories prefixed with
-stubswhich also contains a valid identifier before the-to be type checked.Fixes #8229