Skip to content

PEP 585: Disallow isinstance([1, 2], list[str]) #1311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2020
Merged

PEP 585: Disallow isinstance([1, 2], list[str]) #1311

merged 1 commit into from
Feb 19, 2020

Conversation

ambv
Copy link
Contributor

@ambv ambv commented Feb 18, 2020

The rationale is described in the change itself.

@ambv ambv requested a review from gvanrossum February 18, 2020 23:37
gvanrossum
gvanrossum approved these changes Feb 19, 2020
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enthusiastic +1.

@ambv ambv merged commit 5d77837 into master Feb 19, 2020
@ambv ambv deleted the pep585-disallow-isinstance branch February 19, 2020 11:17
@gvanrossum gvanrossum mentioned this pull request Feb 25, 2020
Merged
5 tasks
mnm678 pushed a commit to mnm678/peps that referenced this pull request Oct 22, 2020
@ambv @mnm678
[pep-585] Disallow isinstance([1, 2], list[str]) (python#1311)
6d92f22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ambv @gvanrossum @the-knights-who-say-ni