Skip to content

Restify PEP 206 #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2016
Merged

Restify PEP 206 #144

merged 1 commit into from
Nov 29, 2016

Conversation

Mariatta
Copy link
Member

Straightforward conversion.
I used my (imperfect) script at https://github.com/Mariatta/restify_me for this.
Feedback are welcome :)

================

The PEP is based on an earlier draft PEP by Moshe Zadka, titled
"2.0 Batteries Included."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PEP does not have the copyright notice, something that's discussed in #123
Should it be added here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe @akuchling (the PEP author) can add one or tell you what it should be? (I presume public domain, like all other PEPs, but it's polite to ask.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gvanrossum :)
I won't make changes wrt copyright notice without @akuchling 's input.
If anything, perhaps it should go in a separate PR anyway?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, adding a copyright can be a separate PR.

@brettcannon
Copy link
Member

So if we skip adding a copyright is this PR ready to be committed?

@Mariatta
Copy link
Member Author

I tested it locally, and it renders fine.
So, maybe it's ok to merge? :)

@brettcannon brettcannon merged commit a6f1efa into python:master Nov 29, 2016
@brettcannon
Copy link
Member

Travis is green so that's good enough for me. 😄

@brettcannon
Copy link
Member

Thanks, BTW!

@Mariatta Mariatta deleted the restify-pep206 branch March 2, 2017 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants