-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Restify PEP 206 #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restify PEP 206 #144
Conversation
================ | ||
|
||
The PEP is based on an earlier draft PEP by Moshe Zadka, titled | ||
"2.0 Batteries Included." | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PEP does not have the copyright notice, something that's discussed in #123
Should it be added here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe @akuchling (the PEP author) can add one or tell you what it should be? (I presume public domain, like all other PEPs, but it's polite to ask.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gvanrossum :)
I won't make changes wrt copyright notice without @akuchling 's input.
If anything, perhaps it should go in a separate PR anyway?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, adding a copyright can be a separate PR.
So if we skip adding a copyright is this PR ready to be committed? |
I tested it locally, and it renders fine. |
Travis is green so that's good enough for me. 😄 |
Thanks, BTW! |
Straightforward conversion.
I used my (imperfect) script at https://github.com/Mariatta/restify_me for this.
Feedback are welcome :)