Conversation
|
Cool! What's the significance of the commented-out ones? Are they ones where you (or your script, since I presume that wasn't made by hand) didn't find any GitHub user names for that PEP? LGTM. Also, PEP 8001 has a lot of authors :) |
|
Thanks for taking the time to do this! If this was generated from a script, maybe that could be committed as well? I'm thinking that doing so would keep it from getting stale, since anyone with a local copy of the voters repo (or something) could refresh it as needed. |
berkerpeksag
left a comment
There was a problem hiding this comment.
LGTM! I agree with Brandt that it would be great to add the script if the file was auto-generated.
|
|
Which I somehow managed to not read. Heh. |
|
It was a team effort between me, VS Code, and a script. 😉 All the script did was list all the PEP file name along with their author names. Replacing the author names was multi-cursor support in VS Code. Looking up the author name was VS Code's GitHub extension and me just knowing. 😄 IOW there's nothing to check in with this to help maintain anything. If this goes in then every new PEP is going to be expected to update |
After merge, perhaps add this to PEP 1? |
willingc
left a comment
There was a problem hiding this comment.
Going ahead and merging this.
|
I was actually putting it off until I had enough time to draft the email to python-committers to announce the change. 😄 I'll go email about this now. |
|
Thanks a lot. This a great work! One small note, I think two surnames may be not handled correctly: https://github.com/python/peps/blob/master/.github/CODEOWNERS#L476 |
|
@pablogsal I fixed this in #1913. I didn't see any similar mistakes elsewhere in the file, including your other PEPs. |
Thanks a lot! ! |
|
@brettcannon Sorry about that. Thanks for taking care of that. |
All active core devs that have either authored or sponsored a PEP are now listed as the "owner" of that PEP file. This will help PEP editors by automatically assigning PRs to the appropriate core devs.
Closes #1804