PEP 563: Correct references to 3.10 default adoption#2086
Merged
gvanrossum merged 3 commits intopython:masterfrom Sep 25, 2021
Merged
PEP 563: Correct references to 3.10 default adoption#2086gvanrossum merged 3 commits intopython:masterfrom
gvanrossum merged 3 commits intopython:masterfrom
Conversation
brettcannon
approved these changes
Sep 21, 2021
gvanrossum
approved these changes
Sep 21, 2021
pep-0563.rst
Outdated
Comment on lines
+286
to
+287
| This is projected to become the default behavior starting in Python 3.11 or | ||
| later. Use of annotations incompatible with this PEP is no longer supported. |
Member
There was a problem hiding this comment.
Since @brettcannon approves I'm okay with this, but we really should wait for the discussion about PEP 649 before we announce any "projections". This may well never become the default behavior, if PEP 649 prevails.
Contributor
Author
There was a problem hiding this comment.
Would it be appropriate to address the current situation in this PEP or are edits generally limited to corrections?
Member
There was a problem hiding this comment.
You can mark it with e.g. Update: or Note:
gvanrossum
reviewed
Sep 25, 2021
Member
gvanrossum
left a comment
gvanrossum
left a comment
There was a problem hiding this comment.
LG except for 1 nit. Thanks!
|
|
||
| Rationale and Goals | ||
| =================== | ||
|
|
Member
There was a problem hiding this comment.
Please put this blank line back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edited two sentences to reflect that PEP 563 won't be default until at least 3.11 if ever.
Resolves #2084