Conversation
JelleZijlstra
commented
Jan 10, 2022
hugovk
reviewed
Jan 10, 2022
Member
hugovk
left a comment
There was a problem hiding this comment.
Plus a few others suggestions:
Line 45:
-Although is possible to currently format long ``assert`` statements over
+Although it is possible to currently format long ``assert`` statements overLine 56:
-the authors of this document believe the parenthesized form is more clear and more consistent with
+the authors of this document believe the parenthesized form is clearer and more consistent withAlso there's a move to discourage references and link directly instead: #2130
So update line 67:
This change has been originally discussed and proposed in [bpo-46167]_.
And line 153 (plus "exist" -> "exists"):
A proposed draft PR with the change exist in [GH-30247]_.
pablogsal
approved these changes
Jan 10, 2022
Member
|
Thanks a lot for the edits @JelleZijlstra 🎉 |
Member
Author
|
Thanks Pablo! Hugo's other suggestions in the message above are still open but I think better handled in a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.