PEP 677: Runtime Behavior Specification#2237
Merged
gvanrossum merged 10 commits intopython:mainfrom Jan 18, 2022
Merged
Conversation
gvanrossum
reviewed
Jan 13, 2022
Contributor
Author
|
Updates:
|
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Member
|
I’m going to have to take a backseat for now, but one source of inspiration could be the ’inspect’ module. |
Contributor
Author
|
Updates:
|
424099b to
e8c71b8
Compare
gvanrossum
reviewed
Jan 18, 2022
Member
gvanrossum
left a comment
There was a problem hiding this comment.
(Some of my more substantive comments can wait for the python-dev discussion if you prefer.)
pep-0677.rst
Outdated
| kind: CallableTypeArgumentKind | ||
| annotation: typing.Type | typing.TypeVar | typing.ParamSpec | ||
|
|
||
| class CallableTypeArgumentKind(Enum): |
Member
There was a problem hiding this comment.
That makes for very long enum names. Although perhaps @global_enum could help?
Contributor
Author
There was a problem hiding this comment.
I didn't know @global_enum was a thing!
Should https://docs.python.org/3.11/library/enum.html say something about it?
I had to do a code search on CPython to confirm it exists, search engines appear to be unaware of it.
Co-authored-by: Guido van Rossum <gvanrossum@gmail.com>
Contributor
Author
|
Updates:
|
gvanrossum
reviewed
Jan 18, 2022
Member
gvanrossum
left a comment
There was a problem hiding this comment.
(Rest looks good, just need to fix two declarations.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had forgotten to port the detailed spec from
https://docs.google.com/document/d/15nmTDA_39Lo-EULQQwdwYx_Q1IYX4dD5WPnHbFG71Lk/edit
(It was originally separate because I was concerned there might be too much debate and thrash to put it in the PEP, but that did not turn out to be true).