PEP 675: Establish typing context in the Abstract#2324
Merged
Conversation
The document was drafted and discussed on typing-sig, which is perfectly acceptable for this PEP. But as a general PEP, it should briefly establish its context.
AA-Turner
changed the title
AA-Turner
approved these changes
Feb 15, 2022
Member
|
Thanks! |
Member
|
cc @pradeep90 |
Member
|
@JelleZijlstra sorry if I merged this too early! I'd seen other activity of yours & assumed you'd seen this. |
Member
|
Yes, I hadn't gotten to this one yet. Better to wait for the PEP author to approve in general, though this change is pretty harmless. |
Member
|
I tend to wait for approval generally but had thought this one was small enough to merge -- will bear in mind for future, sorry. A |
Contributor
|
Yes, we'd have appreciated a heads-up. We would not have known about this change otherwise :) cc @gbleaney |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The document was drafted and discussed on typing-sig, which is perfectly acceptable for this PEP.
But as a general PEP, it should briefly establish its context.
(The PR just adds
Using static type annotations,, splits a sentence that becomes too long, and adjusts capitalization.)