PEP 681: Remove discussion of alternate form#2386
Merged
JelleZijlstra merged 1 commit intopython:mainfrom Mar 7, 2022
debonte:removeAlternateForm
Merged
PEP 681: Remove discussion of alternate form#2386JelleZijlstra merged 1 commit intopython:mainfrom debonte:removeAlternateForm
JelleZijlstra merged 1 commit intopython:mainfrom
debonte:removeAlternateForm
Conversation
JelleZijlstra
approved these changes
Mar 7, 2022
Member
JelleZijlstra
left a comment
JelleZijlstra
left a comment
There was a problem hiding this comment.
Agree, this was useful as an experimental measure but the discussion in the PEP is now confusing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the "Alternate form" section and the mention of the alternate form in the "Reference Implementation" section.
Now that the
dataclass_transformdecorator is available intyping_extensions, the fact that Pyright supports the dundered alternate form (__dataclass_transform__) is not particularly interesting and has caused some reader confusion.This needed to be removed before requesting PEP approval anyway.
cc: @davidfstr