Skip to content

PEP 558: fix footnote references #2754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 17, 2022
Merged

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Aug 9, 2022

Fix these footnotes:

pep-0558.rst:1299: WARNING: Footnote [2] is not referenced.
pep-0558.rst:1323: WARNING: Footnote [10] is not referenced.
pep-0558.rst:1326: WARNING: Footnote [11] is not referenced.
pep-0558.rst:1329: WARNING: Footnote [12] is not referenced.
pep-0558.rst:1332: WARNING: Footnote [13] is not referenced.

[2] was removed in f057675

The others were written like [8,13]_ and [10,11,12]_ instead of [8]_ [13]_ and [10]_ [11]_ [12]_

Also:

  • Remove redundant emacs metadata
  • Fix code formatting (e.g. .. code-block:: c)
  • Fix a couple of typos
  • Update BPO links to GH
  • Convert the references to regular links

Preview

https://pep-previews--2754.org.readthedocs.build/pep-0558/

@hugovk hugovk added the bug label Aug 9, 2022
@hugovk hugovk requested a review from ncoghlan as a code owner August 9, 2022 15:56
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the preview and changes and they LGTM, thanks @hugovk

@hugovk hugovk merged commit a4329d4 into python:main Aug 17, 2022
@hugovk hugovk deleted the pep558-fix-footnotes branch August 17, 2022 05:26
@hugovk
Copy link
Member Author

hugovk commented Aug 17, 2022

Thanks for the reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants