-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
PEP 387: Add Soft Deprecation section #3182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@pfmoore: I addressed some of your comments. |
For people interested about the exact implementation of SoftDeprecationWarning: I created the PR python/cpython#106142. |
@pfmoore: I rephrased the section. Would you mind to review the updated PR? |
I replaced MUST with SHOULD:
becomes:
|
I mark this PR as a draft to prevent merging it by mistake. I will request SC approval to merge it once it will be ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better, thanks. I've suggested one minor change.
Also, note the discussion on Discourse is still ongoing - I favour the idea of removing the association between "deprecated" and "scheduled for removal", in favour of explicitly flagging things that are planned for removal. |
2038da2
to
53dab72
Compare
I updated the PR to no longer issue a warning. |
I submitted this PEP change to the Steering Council: python/steering-council#199 |
"The SC agrees with the proposal and accepts the PEP update": python/steering-council#199 (comment) |
Thanks for the reviews! |
📚 Documentation preview 📚: https://pep-previews--3182.org.readthedocs.build/