Skip to content

PEP 724: Add the Rationale section #3447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 23, 2023
Merged

PEP 724: Add the Rationale section #3447

Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
13065f2
Another potential discussion about this idea
rchiodo Sep 19, 2023
50e30c5
Add a rationale section
rchiodo Sep 19, 2023
f48eaa5
More examples pointed out in discussion thread
rchiodo Sep 19, 2023
da6fc33
Change wording
rchiodo Sep 19, 2023
2a92588
More wording
rchiodo Sep 19, 2023
d3ab2ac
Remove italics around stricter
rchiodo Sep 19, 2023
d6bed7e
Add descriptions for issues
rchiodo Sep 20, 2023
e8b3bbf
Merge branch 'main' into rchiodo/moreposthistory
rchiodo Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions peps/pep-0724.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,19 @@ The following code sample demonstrates both of these limitations.
return ``TypeGuard`` type was not a subtype of the input type. Refer to
:pep:`647` for examples.

Rationale
=========

There are a number of issues where a stricter ``TypeGuard`` would have
been a solution:

* `Python typing issue <https://github.com/python/typing/issues/1351>`__
* `Pyright issue <https://github.com/microsoft/pyright/issues/3450>`__
* `Pyright issue <https://github.com/microsoft/pyright/issues/3466>`__
* `Mypy issue <https://github.com/python/mypy/issues/15305>`__
* `Mypy issue <https://github.com/python/mypy/issues/15520>`__
* `Typeshed issue <https://github.com/python/typeshed/issues/8009>`__


Specification
=============
Expand Down