Skip to content

PEP 544: Specify usage of modules as subtypes of protocols #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2019

Conversation

ilevkivskyi
Copy link
Member

See python/mypy#5018 for motivation.

Attn: @gvanrossum @JukkaL @ambv

Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, but let's wait until the implementation has landed. We might find some unexpected issue.

Also, when next publishing PEP 544 for review on python-dev this should be mentioned in the summary of changes since the last publication. (Don't worry, this isn't going to be another PEP 572. :-)

@ilevkivskyi
Copy link
Member Author

See python/mypy#5322

@ilevkivskyi ilevkivskyi closed this Jul 5, 2018
@gvanrossum
Copy link
Member

gvanrossum commented Jul 5, 2018

Whoa. If you don't feel like working on this, fine, but there's no need to close the PR.

(This PR is waiting for the implementation, one of the items at python/mypy#5322 (comment).)

@gvanrossum gvanrossum reopened this Jul 5, 2018
@brettcannon brettcannon changed the title PEP 544: Specify usage of modules as subtypes of protocols WIP: PEP 544: Specify usage of modules as subtypes of protocols Nov 2, 2018
@brettcannon
Copy link
Member

I tweaked the title to say "WIP" so people know it's still open on purpose.

@ilevkivskyi ilevkivskyi changed the title WIP: PEP 544: Specify usage of modules as subtypes of protocols PEP 544: Specify usage of modules as subtypes of protocols May 11, 2019
@ilevkivskyi
Copy link
Member Author

As we discussed recently, there is no need to wait for full implementation before acceptance (this part of the PEP is not implemented in mypy). I looked at this again, and seems to me this can be merged as is, the current proposal matches the discussion in python/mypy#5322.

@ilevkivskyi ilevkivskyi merged commit 88135b7 into python:master May 11, 2019
@ilevkivskyi ilevkivskyi deleted the allow-modules-for-protocols branch May 11, 2019 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants