Skip to content

Add matrix strategy to test with all supported Python versions #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2023

Conversation

m-aciek
Copy link
Contributor

@m-aciek m-aciek commented Mar 11, 2023

No description provided.

@ghost
Copy link

ghost commented Mar 11, 2023

All commit authors signed the Contributor License Agreement.
CLA signed

@pradyunsg
Copy link
Member

I'll go ahead and merge this, on the basis that this seems like a good idea overall. Holler if you spot something off! :)

@pradyunsg pradyunsg merged commit 932b987 into python:main Mar 11, 2023
@hugovk
Copy link
Member

hugovk commented Mar 11, 2023

Is it possible to add 3.12/main?

Should the doc-html artifact at https://github.com/python/python-docs-theme/actions/runs/4393087253 also include 3.8-3.10?

Left is main, right is this PR:

image

@m-aciek m-aciek deleted the test-on-all-py-versions branch March 11, 2023 19:47
@m-aciek
Copy link
Contributor Author

m-aciek commented Mar 11, 2023

Is it possible to add 3.12/main?

Yes, definitely, I think it's a good idea, I can add a pull request for that.

Should the doc-html artifact at https://github.com/python/python-docs-theme/actions/runs/4393087253 also include 3.8-3.10?

Actually, we should see the jobs for 3.8-3.10 as failed, as my branch wasn't basing on fresh-fixed master. The missing artifacts were because of failed jobs. It looks like exit code of build_docs.py script is incorrectly zero instead of non-zero for failing build. I will try to confirm that and follow it up in builddocs-script GitHub repository.

That's what the artifacts from the Actions on the theme main branch look like for me (all versions from matrix are there):

Zrzut ekranu 2023-03-11 o 21 16 18

@m-aciek
Copy link
Contributor Author

m-aciek commented Mar 12, 2023

Please see PR python/docsbuild-scripts#150.

@m-aciek
Copy link
Contributor Author

m-aciek commented Mar 15, 2023

I just wanted to share a thought that in case of a need of some changes that would break backwards compatibility we can always decide to pin the theme version in CPython branch and remove a version from matrix. But still it will be easier to spot the breakage and pin the version in advance of releasing such changes having those tests in CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants