Skip to content

Commit ce222e5

Browse files
authored
Split requirements file into sections (#10309)
Also note that type checkers and linters should be pinned to a specific version.
1 parent be925c0 commit ce222e5

2 files changed

Lines changed: 11 additions & 5 deletions

File tree

.pre-commit-config.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ repos:
33
rev: v4.4.0 # must match requirements-tests.txt
44
hooks:
55
- id: trailing-whitespace
6-
- id: requirements-txt-fixer
76
- id: end-of-file-fixer
87
- id: check-yaml
98
- id: check-toml

requirements-tests.txt

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,28 @@
1-
aiohttp==3.8.4; python_version < "3.12" # aiohttp can't be installed on 3.12 yet
1+
# Type checkers and other linters that we test our stubs against. These should always
2+
# be pinned to a specific version to make failure reproducible. See also the
3+
# "tool.typeshed" section in pyproject.toml for additional type checkers.
24
black==23.3.0 # must match .pre-commit-config.yaml
35
flake8==6.0.0; python_version >= "3.8" # must match .pre-commit-config.yaml
46
flake8-bugbear==23.5.9; python_version >= "3.8" # must match .pre-commit-config.yaml
57
flake8-noqa==1.3.1; python_version >= "3.8" # must match .pre-commit-config.yaml
68
flake8-pyi==23.5.0; python_version >= "3.8" # must match .pre-commit-config.yaml
79
isort==5.12.0; python_version >= "3.8" # must match .pre-commit-config.yaml
810
mypy==1.3.0
9-
packaging==23.1
10-
pathspec>=0.11.1
1111
pre-commit-hooks==4.4.0 # must match .pre-commit-config.yaml
1212
pycln==2.1.5 # must match .pre-commit-config.yaml
1313
pytype==2023.6.2; platform_system != "Windows" and python_version < "3.11"
14+
15+
# Libraries used by our various scripts.
16+
aiohttp==3.8.4; python_version < "3.12" # aiohttp can't be installed on 3.12 yet
17+
packaging==23.1
18+
pathspec>=0.11.1
1419
pyyaml==6.0
1520
stubdefaulter==0.1.0
1621
termcolor>=2.3
1722
tomli==2.0.1
1823
tomlkit==0.11.8
24+
typing-extensions
25+
26+
# Type stubs used to type check our scripts.
1927
types-pyyaml>=6.0.12.7
2028
types-setuptools>=67.5.0.0
21-
typing-extensions

0 commit comments

Comments
 (0)