Split requirements files into sections - #10309
Merged
Merged
Conversation
Also note that type checkers and linters should be pinned to a specific version.
Member
|
We'll need to get rid of the |
Avasam
reviewed
Jun 12, 2023
Comment on lines
19
to
20
| pycln==2.1.5 # must match .pre-commit-config.yaml | ||
| pytype==2023.6.2; platform_system != "Windows" and python_version < "3.11" |
Collaborator
There was a problem hiding this comment.
Small comment: Given pycln is a formatter and pytype a type-checker, I would've expected to see them in the above section with black/isort and mypy/flake8.
Collaborator
Author
There was a problem hiding this comment.
That was the case before pre-commit destroyed the order. I'll see if I can fix this.
Collaborator
There was a problem hiding this comment.
oh lol, I see.
Might be worth requesting "sort only within groups" as a feature. It feels like a common use-case (I myself am making groups in my requirements file and not using the fixer in my pre-commit for that exact reason).
Removing it atm seems reasonable.
AlexWaygood
reviewed
Jun 12, 2023
AlexWaygood
approved these changes
Jun 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also note that type checkers and linters should be pinned to a specific version.
See typeshed-internal/stub_uploader#96 for context.