-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
HTTPSConnection.__init__(port=)
incorrectly annotated as str | None
for 3.12
#11057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hm, indeed it looks like typeshed/stdlib/http/client.pyi Lines 151 to 156 in 06d0151
Implementation: https://github.com/python/cpython/blob/bfc6d91c784c428c6f5c706a316cdce9140c4753/Lib/http/client.py#L920 |
tada: #11058 |
allisonkarlitskaya
added a commit
to allisonkarlitskaya/typeshed
that referenced
this issue
Nov 22, 2023
Fix an apparent typo in the type of this field. Closes python#11057
AlexWaygood
pushed a commit
that referenced
this issue
Nov 22, 2023
Fix an apparent typo in the type of this field. Closes #11057
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This was introduced in #10392.
As far as I can tell by reading the code, it's only ever valid to give an integer or
None
. This matches the (correct) typeshed annotations forHTTPConnection
and versions before Python 3.12. The problem seems to be specific toHTTPSConnection
and Python 3.12.The text was updated successfully, but these errors were encountered: