Skip to content

Here is a working stub for the chardet package from PyPI #1707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ArneBachmann opened this issue Nov 1, 2017 · 6 comments
Closed

Here is a working stub for the chardet package from PyPI #1707

ArneBachmann opened this issue Nov 1, 2017 · 6 comments
Labels
stubs: request OUTDATED! Request to add stubs for a new package to typeshed

Comments

@ArneBachmann
Copy link

ArneBachmann commented Nov 1, 2017

from typing import Dict, Text, Union

def detect(byte_str:Union[bytes,str]) -> Dict[Text, Text]: ...

into chardet.pyi.

Works for Python3. For Python2 we might need to handle unciode strings somehow, but I'm struggling with that.

@srittau srittau added stubs: request OUTDATED! Request to add stubs for a new package to typeshed size-large labels Oct 28, 2018
@ju-sh
Copy link
Contributor

ju-sh commented Feb 10, 2020

@srittau Hi. Is chardet stub available yet? If not can we start working on it?

@srittau
Copy link
Collaborator

srittau commented Feb 10, 2020

Contributions are welcome! I don't think we have chardet in typeshed yet.

@ju-sh
Copy link
Contributor

ju-sh commented Feb 10, 2020

@srittau Cool. Can we use this issue or is it better to create a new one?

@srittau
Copy link
Collaborator

srittau commented Feb 10, 2020

This issue is fine for discussing the stub, although details should be discussed in the PR once it is opened.

@ju-sh
Copy link
Contributor

ju-sh commented Feb 11, 2020

@srittau Made a tiny part of the stub. Partial. Can you have a look? #3734

@srittau
Copy link
Collaborator

srittau commented Aug 26, 2020

We are closing all third-party stub requests issues without recent activity. We still welcome pull requests that add these to typeshed, although distributing the stubs with the the third-party package itself is preferable.

@srittau srittau closed this as completed Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stubs: request OUTDATED! Request to add stubs for a new package to typeshed
Projects
None yet
Development

No branches or pull requests

3 participants