add stubs for language models #3848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelleZijlstra
requested changes
Mar 14, 2020
| from typing import Tuple | ||
| from . import _LangModelType | ||
|
|
||
| Latin5_BulgarianCharToOrderMap: Tuple[int] |
There was a problem hiding this comment.
Should be Tuple[int, ...] (an arbitrary-length tuple), not Tuple[int] (a tuple of length 1).
Technically this seems to be about a 255-tuple, but I don't really think we need a Tuple[int, int, ... 255 times].
This also goes for the other Tuple[int]s in these stubs.
vishalkuo
pushed a commit
to vishalkuo/typeshed
that referenced
this pull request
Jun 26, 2020
* add stubs for language models * fix syntax error in __init__.pyi * fix syntax error in universaldetector.pyi * remove erroneous imports * delete cli directory * make tuple types variable length
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added stubs for some language models.
As part of #1707