Change some os.path stubs to acknowledge fspath protocol support in >=Python3.6 #1997

brycepg · 2018-03-29T00:17:41Z

Example:

from pathlib import Path
import os
os.path.join(Path("."), '..')

Is valid python because Python3.6 os.path has been changed to accept the __fspath__ protocol
However mypy outputs:

t.py:3: error: Value of type variable "AnyStr" of "join" cannot be "object"

Relevant location: https://github.com/python/typeshed/blob/master/stdlib/3/os/path.pyi#L79

The text was updated successfully, but these errors were encountered:

Fixes python#1997. This is tricky because we need to get the return values right (see python#1960 for prior attempts) and we often run into python/mypy#3644. I found that I could express most signatures correctly using a series of overloads. A few other changes in here: - Added splitunc, which according to https://docs.python.org/3/library/os.path.html should exist in both Unix and Windows. - Made the second argument to os.path.curdir Optional to match the implementation. - Fixed os.path.split, whose previous Path-aware signature triggered python/mypy#3644. I used the following test program to make sure mypy accepted the signatures used here:

Fixes #1997, #2068. This is tricky because we need to get the return values right (see #1960 for prior attempts) and we often run into python/mypy#3644. I found that I could express most signatures correctly using a series of overloads. A few other changes in here: - Added splitunc, which according to https://docs.python.org/3/library/os.path.html should exist in both Unix and Windows. - Made the second argument to os.path.curdir Optional to match the implementation. - Fixed os.path.split, whose previous Path-aware signature triggered python/mypy#3644.

Fixes python#1997, python#2068. This is tricky because we need to get the return values right (see python#1960 for prior attempts) and we often run into python/mypy#3644. I found that I could express most signatures correctly using a series of overloads. A few other changes in here: - Added splitunc, which according to https://docs.python.org/3/library/os.path.html should exist in both Unix and Windows. - Made the second argument to os.path.curdir Optional to match the implementation. - Fixed os.path.split, whose previous Path-aware signature triggered python/mypy#3644.

This was referenced Apr 14, 2018

add __fspath__ support to os.path #2053

Merged

State of os.path and path types #1841

Closed

JakobGM mentioned this issue Apr 19, 2018

Expand environment variables JakobGM/astrality#19

Merged

JelleZijlstra self-assigned this May 14, 2018

JelleZijlstra closed this as completed in #2053 May 15, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change some os.path stubs to acknowledge fspath protocol support in >=Python3.6 #1997

Change some os.path stubs to acknowledge fspath protocol support in >=Python3.6 #1997

brycepg commented Mar 29, 2018

Change some os.path stubs to acknowledge __fspath__ protocol support in >=Python3.6 #1997

Change some os.path stubs to acknowledge __fspath__ protocol support in >=Python3.6 #1997

Comments

brycepg commented Mar 29, 2018

Change some os.path stubs to acknowledge fspath protocol support in >=Python3.6 #1997

Change some os.path stubs to acknowledge fspath protocol support in >=Python3.6 #1997