Skip to content

Missing type annotations for properties on logging.LoggerAdapter #5015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yoavp10 opened this issue Feb 10, 2021 · 2 comments
Closed

Missing type annotations for properties on logging.LoggerAdapter #5015

yoavp10 opened this issue Feb 10, 2021 · 2 comments

Comments

@yoavp10
Copy link

yoavp10 commented Feb 10, 2021

Hi,
LoggerAdapter class have 2 new properties starting from version 3.6*:
manager (getter and setter)
name (getter)

This have no equivalent in typeshed, I'd like to create them. What do you think?

*Unfortunately these properties can't be found on the official cpython docs, however I found the relevant python bug and pr's:
https://bugs.python.org/issue31457
python/cpython@cf2a4f9
python/cpython@fee0475
I opened a docs bug for cpython and plan on making a PR on this front too.

@Akuli
Copy link
Collaborator

Akuli commented Feb 10, 2021

I believe the typeshed convention is to add attributes like this with a comment # undocumented. Even pull requests adding _non_public attributes are accepted when someone needs those non-public attributes.

@yoavp10 yoavp10 changed the title Missing type annotations for properties on logging.LoggerAdapter Missing type annotations for properties on logging.LoggerAdapter #undocumented Feb 10, 2021
@yoavp10 yoavp10 changed the title Missing type annotations for properties on logging.LoggerAdapter #undocumented Missing type annotations for properties on logging.LoggerAdapter # undocumented Feb 10, 2021
@yoavp10 yoavp10 changed the title Missing type annotations for properties on logging.LoggerAdapter # undocumented Missing type annotations for properties on logging.LoggerAdapter Feb 10, 2021
@Akuli
Copy link
Collaborator

Akuli commented May 12, 2021

fixed in #5388

@Akuli Akuli closed this as completed May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants