You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I believe the typeshed convention is to add attributes like this with a comment # undocumented. Even pull requests adding _non_public attributes are accepted when someone needs those non-public attributes.
yoavp10
changed the title
Missing type annotations for properties on logging.LoggerAdapter
Missing type annotations for properties on logging.LoggerAdapter #undocumented
Feb 10, 2021
yoavp10
changed the title
Missing type annotations for properties on logging.LoggerAdapter #undocumented
Missing type annotations for properties on logging.LoggerAdapter # undocumented
Feb 10, 2021
yoavp10
changed the title
Missing type annotations for properties on logging.LoggerAdapter # undocumented
Missing type annotations for properties on logging.LoggerAdapter
Feb 10, 2021
Hi,
LoggerAdapter class have 2 new properties starting from version 3.6*:
manager (getter and setter)
name (getter)
This have no equivalent in typeshed, I'd like to create them. What do you think?
*Unfortunately these properties can't be found on the official cpython docs, however I found the relevant python bug and pr's:
https://bugs.python.org/issue31457
python/cpython@cf2a4f9
python/cpython@fee0475
I opened a docs bug for cpython and plan on making a PR on this front too.
The text was updated successfully, but these errors were encountered: