Add some missing logging features

[spagh-eddie]

This handles #5257, #5015, and changes two type to Type[...] for #343

---

Note I annotated validation_pattern, IDENTIFIER, and extMatch as Any since I cannot do this, which would make a variable, not a type alias.

if sys.version_info >= (3, 7):
    import re
    _Pattern = re.Pattern
else:
    import regex
    _Pattern = regex.Regex
IDENTIFIER: _Pattern

---

Please note that SMTPHandler.password is not always created depending on what is passed in! But since I know of no workarounds for maybe-exsiting-attributes and the documents suggest:

we usually prefer false negatives (no errors for wrong code) over false positives (type errors for correct code)

I have added it password: str.

---

I am not fixing everything I see in this PR, I have left a lot of logging.config as-is

$ stubtest logging --custom-typeshed-dir . --concise
logging.config.BaseConfigurator is not present in stub
logging.config.ConvertingDict is not present in stub
logging.config.ConvertingList is not present in stub
logging.config.ConvertingMixin is not present in stub
logging.config.ConvertingTuple is not present in stub
logging.config.DictConfigurator is not present in stub
logging.config.dictConfigClass is not present in stub

[github-actions]

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

[srittau]

Thank you, that's very thorough! A few minor notes below about the things you mentioned.

[wiseaidev]

I think line format could be a string like: '%(something)s %(something)s'. So, linefmt should be changed to:

    linefmt: Union[str, Formatter]

[Akuli]

Technically it can be anything with a .format() method, even a string. But that .format() method will be called with only one argument, a log record object. It is possible to create a string that formats them in a useful way, such as "{0.name}: {0.msg}", although that doesn't seem to be how it's intended to be used.

[wiseaidev]

Yup!

[srittau]

So the correct fix would be a protocol? We could leave as Any for the moment, though.

[Akuli]

Honestly I would just use Formatter. It's what the author of the code intended. (This is old code, likely written before str.format was a thing)

[spagh-eddie]

I was under the same impression as @Akuli, intended to be a Formatter

[wiseaidev]

Same here:

    def __init__(self, linefmt: Optional[Union[str, Formatter]] = ...) -> None: ...

[srittau]

If someone want to change Formatter to a protocol, they can do it in a separate PR. I'm fine with it being a concrete class for now.