Skip to content

Checks don't run on stubsabot PRs #8434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hauntsaninja opened this issue Jul 29, 2022 · 2 comments · Fixed by #8844
Open

Checks don't run on stubsabot PRs #8434

hauntsaninja opened this issue Jul 29, 2022 · 2 comments · Fixed by #8844
Labels
project: infrastructure typeshed build, test, documentation, or distribution related

Comments

@hauntsaninja
Copy link
Collaborator

However, you can trigger them by manually closing and re-opening.

This isn't an ideal state of things. There's a list of possible workarounds here: https://github.com/peter-evans/create-pull-request/blob/main/docs/concepts-guidelines.md#workarounds-to-trigger-further-workflow-runs

@AlexWaygood
Copy link
Member

There's a list of possible workarounds here: https://github.com/peter-evans/create-pull-request/blob/main/docs/concepts-guidelines.md#workarounds-to-trigger-further-workflow-runs

I like the sound of the last option on this list best: creating a minimal GitHub App that would generate tokens for use with GitHub Actions. The only downside I can see is that the app would have to be associated with a maintainer's personal account, so if the maintainer stopped being active for whatever reason, it might be difficult for other maintainers to get access to the app. I think it would still be better than the current state of affairs, however -- if others agree, I'm happy to set up a GitHub App to do this?

@AlexWaygood
Copy link
Member

Oh, actually, the ssh key option would maybe be better. I was worried that it wouldn't work so well, because of the fact that it only works with push events, rather than pull_request events. But that shouldn't be an issue: stubsabot creates new branches on the typeshed fork, and we can easily adjust the tests.yml workflow so that it runs on push events for any branches starting with stubsabot/. The ssh option is used by oddbird/MetaDeploy here, and they seem pretty happy about it (they wrote a nice blog post about their automated PRs for uprading dependencies here.)

AlexWaygood added a commit that referenced this issue Oct 4, 2022
Fixes #8434.

This uses a new ssh key that @JelleZijlstra just set up for our repo ([this option](https://github.com/peter-evans/create-pull-request/blob/main/docs/concepts-guidelines.md#push-using-ssh-deploy-keys) in Peter Evans's guide to getting checks to run on automated PRs. It seems to be a good option in terms of both security and usability. It's also the option used by `oddbird/MetaDeploy` [here](https://github.com/oddbird/MetaDeploy/blob/main/.github/workflows/upgrade-deps.yml#L20), and they seem pretty happy about it (they wrote a nice blog post about their automated PRs for uprading dependencies [here](https://www.oddbird.net/2022/06/01/dependabot-single-pull-request/).)
hauntsaninja pushed a commit that referenced this issue Oct 4, 2022
Fixes #8434.

This uses a new ssh key that @JelleZijlstra just set up for our repo ([this option](https://github.com/peter-evans/create-pull-request/blob/main/docs/concepts-guidelines.md#push-using-ssh-deploy-keys) in Peter Evans's guide to getting checks to run on automated PRs. It seems to be a good option in terms of both security and usability. It's also the option used by `oddbird/MetaDeploy` [here](https://github.com/oddbird/MetaDeploy/blob/main/.github/workflows/upgrade-deps.yml#L20), and they seem pretty happy about it (they wrote a nice blog post about their automated PRs for uprading dependencies [here](https://www.oddbird.net/2022/06/01/dependabot-single-pull-request/).)
@hauntsaninja hauntsaninja reopened this Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project: infrastructure typeshed build, test, documentation, or distribution related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants