Skip to content

Stubsabot isn't updating open stubsabot PRs #8778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AlexWaygood opened this issue Sep 21, 2022 · 2 comments · Fixed by #8813
Closed

Stubsabot isn't updating open stubsabot PRs #8778

AlexWaygood opened this issue Sep 21, 2022 · 2 comments · Fixed by #8813
Labels
project: infrastructure typeshed build, test, documentation, or distribution related

Comments

@AlexWaygood
Copy link
Member

AlexWaygood commented Sep 21, 2022 •
edited
Loading

If I understand correctly, stubsabot has logic that should mean that it auto-updates PRs (providing no manual changes have been made to the PR branch by maintainers).

That part of the script doesn't seem to be working correctly. #8490 was filed by stubsabot on August 5th, to bump types-stripe from 3.5.* to 4.0.*. But since then, stripe 4.1 was released on August 19th. Since no maintainers have pushed to that PR branch, I think stubsabot should have force-pushed to that branch so that the PR proposes updating to 4.1.* instead of 4.0.* -- but it hasn't.

#8778 (comment)
@AlexWaygood AlexWaygood added the project: infrastructure typeshed build, test, documentation, or distribution related label Sep 21, 2022
@AlexWaygood AlexWaygood mentioned this issue Sep 21, 2022
Open
hauntsaninja added a commit to hauntsaninja/typeshed that referenced this issue Sep 30, 2022
@hauntsaninja
Update open stubsabot PRs
a63bbad 
Fixes python#8778

Note that not fixing this has some advantages, particularly if stubsabot
waits a little while after releases before making PRs (as discussed
earlier). Specifically, it gives us more coverage of upstream versions
and might provide a natural division of changes, compared to PRs that
make updates corresponding to several upstream versions.
@hauntsaninja hauntsaninja mentioned this issue Sep 30, 2022
Merged
JelleZijlstra pushed a commit that referenced this issue Oct 4, 2022
@hauntsaninja
Update open stubsabot PRs (#8813)
807f3a8 
Fixes #8778

Note that not fixing this has some advantages, particularly if stubsabot
waits a little while after releases before making PRs (as discussed
earlier). Specifically, it gives us more coverage of upstream versions
and might provide a natural division of changes, compared to PRs that
make updates corresponding to several upstream versions.
@AlexWaygood AlexWaygood reopened this Oct 4, 2022
hauntsaninja added a commit to hauntsaninja/typeshed that referenced this issue Oct 4, 2022
@hauntsaninja
stubsabot: add some debug logs
0d490a1 
For python#8778
@hauntsaninja hauntsaninja mentioned this issue Oct 4, 2022
Merged
JelleZijlstra pushed a commit that referenced this issue Oct 4, 2022
@hauntsaninja
stubsabot: add some debug logs (#8850)
9b5ea00 
For #8778
@hauntsaninja
Copy link
Collaborator

Okay, I think #8851 fixed this. Although interestingly it shows up as @JelleZijlstra force pushing. I also think that updating might be annoying with the change to daily. I still kind of believe what I said here: #8813 (comment)

@AlexWaygood
Copy link
Member Author

I also think that updating might be annoying with the change to daily.

Yeah, I now see what you mean. I think #8854 might make it better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
project: infrastructure typeshed build, test, documentation, or distribution related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update open stubsabot PRs hauntsaninja/typeshed
2 participants
@hauntsaninja @AlexWaygood