Skip to content

openpyxl Worksheet rows is incorrectly typed #9904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Vegemash opened this issue Mar 20, 2023 · 2 comments
Closed

openpyxl Worksheet rows is incorrectly typed #9904

Vegemash opened this issue Mar 20, 2023 · 2 comments
Labels
stubs: false positive Type checkers report false errors

Comments

@Vegemash
Copy link

Worksheet:rows is typed as Generator[Cell, None, None]. All it does is call self.iter_rows() (no args) and thus should be typed Generator[tuple[Cell, ...], None, None]
srittau added a commit to srittau/typeshed that referenced this issue Mar 20, 2023
@srittau
Fix Worksheet.rows and .values
71463c4 
Closes: python#9904
@srittau
Copy link
Collaborator

srittau commented Mar 20, 2023

Thanks! I added the fix to my PR #9892.

@srittau srittau added the stubs: false positive Type checkers report false errors label Mar 20, 2023
@Avasam
Copy link
Collaborator

Avasam commented Apr 27, 2023

@srittau Seems this issue should be closed?

@srittau srittau closed this as completed Apr 27, 2023
@ostr00000 ostr00000 mentioned this issue Sep 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stubs: false positive Type checkers report false errors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@srittau @Avasam @Vegemash