Revert "[stubsabot] Mark pyvmomi as obsolete since 8.0.1.0 (#10148)" #10171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
)" This reverts commit 853d01d.
|
Note that if this is merged, stubsabot will quickly propose a PR to mark the stubs as obsolete again. We'll just have to sit on that PR until pyvmomi cut a new release that doesn't have syntax errors in the stub files. |
JelleZijlstra
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 853d01d.
As per #10149 (comment), it seems like the stubs bundled with the upstream
pyvmomipackage aren't currently usable due to syntax errors. Given that marking the stubs as obsolete causes a line to be added to the PyPI description instructing users to uninstalltypes-pyvmomi, it seems like we should probably not mark the stubs as obsolete until the upstream types are free of syntax errors.