stub for statistics #1021
Merged
stub for statistics #1021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65 tasks
ambv
reviewed
Mar 18, 2017
stdlib/3.4/statistics.pyi
Outdated
|
|
||
| class StatisticsError(ValueError): ... | ||
|
|
||
| def mean(data: Iterable[_Number]) -> _Number: ... |
There was a problem hiding this comment.
A mean of ints returns a float.
There was a problem hiding this comment.
Hm yes. I wonder if we could just drop int from the typevar and rely on automatic int-to-float promotion.
There was a problem hiding this comment.
Yes, I think that should work. It would lie slightly in that something like statistics.median([1, 2, 3]) will in fact return int but mypy would infer it to return float, but that seems harmless.
There was a problem hiding this comment.
In fact, median for ints returns a float if the number of elements is even. So I think we're good :)
ambv
reviewed
Mar 18, 2017
stdlib/3.4/statistics.pyi
Outdated
|
|
||
| from decimal import Decimal | ||
| from fractions import Fraction | ||
| from typing import Iterable, TypeVar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.python.org/3/library/statistics.html