Skip to content

Add missing __eq__ to Mapping #10297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 10, 2023
Merged

Add missing __eq__ to Mapping #10297

merged 3 commits into from
Jun 10, 2023

Conversation

Dreamsorcerer
Copy link
Contributor

@github-actions

This comment has been minimized.

@Dreamsorcerer
Copy link
Contributor Author

The new error from mypy primer is because they've typed it with Self[K], should be fine for them to type it as object like everything else:
https://github.com/ibis-project/ibis/blob/master/ibis/common/egraph.py#L101

The removed errors from streamlit are exactly the false positives that caused me to look at this (but, in a different library).

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, just one comment — see above

Co-authored-by: Alex Waygood <[email protected]>
@github-actions
Copy link
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

ibis (https://github.com/ibis-project/ibis)
+ ibis/common/egraph.py:101: error: Argument 1 of "__eq__" is incompatible with supertype "Mapping"; supertype defines the argument type as "object"  [override]

streamlit (https://github.com/streamlit/streamlit)
- lib/tests/streamlit/connections/base_connection_test.py: note: In member "test_secrets_property_no_matching_section" of class "ExperimentalBaseConnectionDefaultMethodTests":
- lib/tests/streamlit/connections/base_connection_test.py:58:16: error: Non-overlapping equality check (left operand type: "AttrDict", right operand type: "Dict[<nothing>, <nothing>]")  [comparison-overlap]
- lib/tests/streamlit/connections/base_connection_test.py: note: In member "test_secrets_property_no_secrets" of class "ExperimentalBaseConnectionDefaultMethodTests":
- lib/tests/streamlit/connections/base_connection_test.py:62:16: error: Non-overlapping equality check (left operand type: "AttrDict", right operand type: "Dict[<nothing>, <nothing>]")  [comparison-overlap]

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants