Update vscode recommended settings #10314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
commented
Jun 13, 2023
| // Obsoleted by Pylance | ||
| "ms-pyright.pyright", | ||
| ], | ||
| "recommendations": [ |
There was a problem hiding this comment.
Lots of whitespace changes because apparently last time I didn't "format on save" this file. This respects the configuration in .editorconfig and .vscode/settings.json.
Avasam
commented
Jun 13, 2023
| "--python-version=3.7", | ||
| "--strict" | ||
| // Needed because a library stubbed in typeshed won't necessarily be installed inthe dev's environment | ||
| // Currentyl broken in dmypy: https://github.com/python/mypy/issues/10709 |
There was a problem hiding this comment.
Pinging python/mypy#10709 for reference
srittau
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been a while, and I've kept accumulating changes. I figured with the new
ms-python.mypy-type-checkerextension it might be a good time to provide an update to these recommendations.