Skip to content

Remove stubs for urllib3 #10812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2023
Merged

Conversation

AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Sep 30, 2023

Fixes #6898.
Fixes #10142.

Note that this has a significant impact on the number of stubs packages with non-types dependencies. Both types-requests and types-influxdb-client now depend on urllib3>=2 instead of types-urllib3. That in turn means that types-caldav, types-slumber and types-requests-oauthlib all depend indirectly on urllib3, since all three stubs packages depend on types-requests. All of that might mean that mypy_test.py and regr_test.py slow down a bit. If so, I have some ideas for mitigations I could work on in future PRs for speeding them up a bit.

@AlexWaygood
Copy link
Member Author

N.B. I checked stubtest for types-caldav, types-slumber and types-requests-oauthlib all locally; everything was green

@AlexWaygood
Copy link
Member Author

All of that might mean that mypy_test.py and regr_test.py slow down a bit.

Looks like regr_test.py in particular gets a bit slower, but nothing too catastrophic :)

@github-actions
Copy link
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

pwndbg (https://github.com/pwndbg/pwndbg)
+ pwndbg/commands/ai.py:16: note: ... from here:
+ pwndbg/commands/ai.py:16: note: ... from here:
+ pwndbg/commands/ai.py:16: note: ... from here:
+ pwndbg/commands/ai.py:16: note: ... from here:

@AlexWaygood AlexWaygood marked this pull request as ready for review September 30, 2023 20:07
@AlexWaygood AlexWaygood merged commit 559d31c into python:main Sep 30, 2023
@AlexWaygood AlexWaygood deleted the remove-urllib3 branch September 30, 2023 23:01
nehaljwani added a commit to regro-cf-autotick-bot/types-requests-feedstock that referenced this pull request Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[requests] Change urllib3 dependency Remove urllib3 types (not before October 2023)
2 participants