Skip to content

Split struct_rusage into a separate file #11337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

srittau
Copy link
Collaborator

@srittau srittau commented Jan 29, 2024

This is an attempt to work around the intermittent
mypy crashes while running the test cases.

@srittau
Copy link
Collaborator Author

srittau commented Jan 29, 2024

Cf. #11220

Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@AlexWaygood
Copy link
Member

LGTM. Since I managed to repro the crash locally, I can try to find time to stress-test this, to check if it does fix the crash. Or we can just merge this now and hope it fixes things -- we can always revert it later if the error still persists. I'm easy either way :)

@srittau
Copy link
Collaborator Author

srittau commented Jan 29, 2024

A stress test would be good, I think. I'm not really convinced that this PR fixes things.

@AlexWaygood
Copy link
Member

AlexWaygood commented Jan 30, 2024

Regrettably.....

Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "C:\Users\alexw\coding\typeshed\.venv\Lib\site-packages\mypy\__main__.py", line 37, in <module>
    console_entry()
  File "C:\Users\alexw\coding\typeshed\.venv\Lib\site-packages\mypy\__main__.py", line 15, in console_entry
    main()
  File "mypy\main.py", line 100, in main
  File "mypy\main.py", line 182, in run_build
  File "mypy\build.py", line 191, in build
  File "mypy\build.py", line 265, in _build
  File "mypy\build.py", line 2943, in dispatch
  File "mypy\build.py", line 3334, in process_graph
  File "mypy\build.py", line 3415, in process_fresh_modules
  File "mypy\build.py", line 2111, in fix_cross_refs
  File "mypy\fixup.py", line 52, in fixup_module
  File "mypy\fixup.py", line 127, in visit_symbol_table
  File "mypy\lookup.py", line 31, in lookup_fully_qualified
AssertionError: Cannot find module for _resource_rusage.struct_rusage

Hit during the second iteration of the script I posted in #11220 (comment)

@srittau srittau closed this Jan 30, 2024
@srittau srittau deleted the struct-rusage branch January 30, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants