-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Move resource.struct_rusage import #11343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Oh no..... on the eighteenth iteration I get:
I'll get a bigger sample size and see if this is still worth merging |
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
At least that's a different import, wasn't it always |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also see struct_rusage
in some failures. With larger sample size, I'm not sure that this is any better, but don't think this is any worse. I kind of prefer this aesthetically, so I'm going to merge it and we'll see if it makes any marginal difference.
I'm getting flaky failures going back several months too. My guess is we just shouldn't be invoking mypy in parallel or should be setting --no-incremental
or something.
My current working theory is that there was a latent race condition (due to running many mypys concurrently) that was already present (and has probably always been present since #10714), but was recently made significantly more likely to occur, probably due to our import cycles getting worse |
Fixes #1122017 iterations of Alex's script and counting...