improve type annotations in 'docutils.readers.doctree' #11492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieleades
force-pushed
the
docutils.readers.doctree
branch
from
446f938 to
0ca6a84
Compare
22 tasks
This comment has been minimized.
This comment has been minimized.
|
Could you fix the merge conflict? I tried to do it in the UI but it didn't go through. |
i've done so, but i'm seeing a bug in github in the last few hours where the PR is not updating when new commits are pushed to the branch looks like github is experiencing some issues: https://www.githubstatus.com/ |
danieleades
force-pushed
the
docutils.readers.doctree
branch
from
80c446a to
c9cfc74
Compare
danieleades
force-pushed
the
docutils.readers.doctree
branch
from
c9cfc74 to
cc05410
Compare
|
github seems to have sorted itself out now |
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is stacked on #11490
i'll admit it turned out to be pretty simple...