[WIP] improve type annotations in 'docutils.parsers.rst.states' #11525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 tasks
This comment has been minimized.
This comment has been minimized.
danieleades
force-pushed
the
docutils.parsers.rst.states
branch
from
b2ddcf2 to
698e1eb
Compare
This comment has been minimized.
This comment has been minimized.
danieleades
force-pushed
the
docutils.parsers.rst.states
branch
from
dcd3f5f to
139c522
Compare
danieleades
force-pushed
the
docutils.parsers.rst.states
branch
from
b1a0822 to
be286e0
Compare
|
@JelleZijlstra I think this PR should not me merged before #11469 because the addition of generics in |
danieleades
force-pushed
the
docutils.parsers.rst.states
branch
from
934e3f5 to
2c26ae8
Compare
This comment has been minimized.
This comment has been minimized.
|
Diff from mypy_primer, showing the effect of this PR on open source code: sphinx (https://github.com/sphinx-doc/sphinx)
+ sphinx/util/nodes.py:588: error: Unused "type: ignore" comment [unused-ignore]
+ sphinx/util/docutils.py:507: error: Unused "type: ignore" comment [unused-ignore]
- sphinx/util/docutils.py: note: In member "env" of class "SphinxRole":
- sphinx/util/docutils.py:497:16: error: "Inliner" has no attribute "document" [attr-defined]
- sphinx/roles.py: note: In member "create_non_xref_node" of class "XRefRole":
- sphinx/roles.py:117:34: error: "Inliner" has no attribute "document" [attr-defined]
- sphinx/roles.py: note: In member "create_xref_node" of class "XRefRole":
- sphinx/roles.py:142:34: error: "Inliner" has no attribute "document" [attr-defined]
- sphinx/roles.py: note: In member "run" of class "PEP":
- sphinx/roles.py:182:9: error: "Inliner" has no attribute "document" [attr-defined]
- sphinx/roles.py:193:19: error: "Inliner" has no attribute "reporter" [attr-defined]
- sphinx/roles.py:195:19: error: "Inliner" has no attribute "problematic" [attr-defined]
- sphinx/roles.py: note: In member "build_uri" of class "PEP":
- sphinx/roles.py:201:20: error: "Inliner" has no attribute "document" [attr-defined]
- sphinx/roles.py: note: In member "run" of class "RFC":
- sphinx/roles.py:216:9: error: "Inliner" has no attribute "document" [attr-defined]
- sphinx/roles.py:227:19: error: "Inliner" has no attribute "reporter" [attr-defined]
- sphinx/roles.py:229:19: error: "Inliner" has no attribute "problematic" [attr-defined]
- sphinx/roles.py: note: In member "build_uri" of class "RFC":
- sphinx/roles.py:235:20: error: "Inliner" has no attribute "document" [attr-defined]
- sphinx/roles.py:238:31: error: "Inliner" has no attribute "rfc_url" [attr-defined]
- sphinx/roles.py:240:31: error: "Inliner" has no attribute "rfc_url" [attr-defined]
bokeh (https://github.com/bokeh/bokeh)
+ src/bokeh/sphinxext/bokeh_palette_group.py:53: note: ... from here:
- src/bokeh/sphinxext/bokeh_palette_group.py:53: note: In module imported here:
+ src/bokeh/sphinxext/bokeh_palette_group.py:53: note: ... from here:
|
|
this rebase is beyond me. will close it and reopen a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note to reviewers: i don't love the amount of
type: ignorestatements I'm having to put in here to match the implementation in docutils. Would welcome input if there's a better approach