-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Document the supported stdlib versions #12731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CONTRIBUTING.md
Outdated
@@ -117,7 +117,9 @@ hard-linked extension modules, and the builtins. The `VERSIONS` file lists | |||
the versions of Python where the module is available. | |||
|
|||
We accept changes for future versions of Python after the first beta for that | |||
version was released. | |||
version was released. We will drop active support for a Python version three |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe something like "We will cease actively testing support for a Python version"? The stubs for that version will probably continue to be entirely accurate in the three months when the version is untested but the branches are still there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do more than that, though. We will declare end of support in the docs. I don't think we need to be completely accurate, especially since this policy is mostly relevant to typeshed and type checker developers. End users are only indirectly affected through their type checkers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough. I'd prefer to be precise here since these CONTRIBUTING docs are already not exactly concise, so I don't think the marginal impact of another sentence is particularly big! But I don't have a strong opinion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree that it's useful to be precise about our versioning policy, so we don't have to wrangle over it again next year when we start to think about dropping 3.9.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My comment was contradictory anyway. Precision is good, but I want to word it in a way that makes it clear that official support is dropped after 2-3 months.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Co-authored-by: Alex Waygood <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggested fixed numbers. I think a range isn't too helpful (in practice people always end up aiming to do either the lower bound or the upper bound, and may as well be explicit)
Co-authored-by: Shantanu <[email protected]>
Closes: #12716