Fix stub for networkx.algorithms.approximation.treewidth
#14983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srittau
requested changes
Nov 5, 2025
| def best_node(self, graph: dict[_Node, set[_Node]]) -> _Node | None: ... | ||
|
|
||
| def min_fill_in_heuristic(graph_dict) -> Incomplete | None: ... | ||
| def min_fill_in_heuristic(graph_dict: dict[_Node, set[_Node]]) -> _Node | None: ... |
There was a problem hiding this comment.
We could use a protocol for graph_dict. Unfortunately, _typeshed.SupportsLenAndGetItem is not generic over the item type, but collections.abc.Mapping would be an improvement for now.
There was a problem hiding this comment.
Thanks for pointing out. Updated
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title.
Based on implementation at https://github.com/networkx/networkx/blob/8b1c5a1/networkx/algorithms/approximation/treewidth.py