Skip to content

Use typing.ContextManager to fix multiprocessing context managers #1557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

OddBloke
Copy link
Contributor

No description provided.

@JelleZijlstra
Copy link
Member

Can you clarify what this is "fixing"? Is it about passing these objects to functions that expect a ContextManager?

@OddBloke
Copy link
Contributor Author

I actually started just looking at missing types (from the warnings in #1526), and that's what I was referring to fixing. Using ContextManager seemed like the best way to address the lack of types on __enter__ and __exit__, and being able to use them as generic context managers is a nice side effect.

@OddBloke
Copy link
Contributor Author

When looking at #1559, I've modified this code further, so I'll close this out and open a fresh PR with those changes.

@OddBloke OddBloke closed this Aug 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants