Skip to content

Add 3-argument overload for asyncio.gather. #1644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2017

Conversation

carljm
Copy link
Member

@carljm carljm commented Oct 3, 2017

This was overlooked in #1550.

@@ -32,6 +32,9 @@ def gather(coro_or_future1: _FutureT[_T1], coro_or_future2: _FutureT[_T2],
*, loop: AbstractEventLoop = ..., return_exceptions: bool = False) -> Future[Tuple[_T1, _T2]]: ...
@overload
def gather(coro_or_future1: _FutureT[_T1], coro_or_future2: _FutureT[_T2], coro_or_future3: _FutureT[_T3],
*, loop: AbstractEventLoop = ..., return_exceptions: bool = False) -> Future[Tuple[_T1, _T2. _T3]]: ...
Copy link
Member

@JelleZijlstra JelleZijlstra Oct 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the . needs to be a , (between T2 and T3)

@carljm carljm force-pushed the complete-gather-stub branch from aed1964 to 7e32732 Compare October 3, 2017 17:43
@carljm carljm force-pushed the complete-gather-stub branch from 7e32732 to 09af79f Compare October 3, 2017 17:47
@JelleZijlstra JelleZijlstra merged commit a19d4e3 into python:master Oct 3, 2017
@JelleZijlstra
Copy link
Member

Thanks for catching this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants