Rearrange overloads to account for optional arguments #2150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically, the same thing as [my previous pull request][0], except the fixes are now focusing on functions with overlapping argument counts. [0]: python#2138
| @@ -140,9 +140,9 @@ else: | |||
| def join(path: AnyStr, *paths: AnyStr) -> AnyStr: ... | |||
|
|
|||
| @overload | |||
| def relpath(path: _StrPath, start: Optional[_StrPath] = ...) -> Text: ... # type: ignore | |||
| def relpath(path: _BytesPath, start: _BytesPath) -> bytes: ... # type: ignore | |||
There was a problem hiding this comment.
Can you apply the same ordering change to stdlib3/os/path.pyi?
Michael0x2a
added a commit
to Michael0x2a/mypy
that referenced
this pull request
May 20, 2018
This time mostly to incorporate python/typeshed#2150
Michael0x2a
added a commit
to python/mypy
that referenced
this pull request
May 20, 2018
This time mostly to incorporate python/typeshed#2150.
gwk
pushed a commit
to gwk/typeshed
that referenced
this pull request
May 29, 2018
Basically, the same thing as [my previous pull request][0], except the fixes are now focusing on functions with overlapping argument counts. [0]: python#2138
yedpodtrzitko
pushed a commit
to yedpodtrzitko/typeshed
that referenced
this pull request
Jan 23, 2019
Basically, the same thing as [my previous pull request][0], except the fixes are now focusing on functions with overlapping argument counts. [0]: python#2138
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, the same thing as my previous pull request, except the fixes are now focusing on functions with overlapping argument counts.