pynamodb: fix rate_limited_scan defaults #2167
Conversation
The `rate_limited_scan` method has defaults for all arguments, including `attributes_to_get` which was omitted.
There was a problem hiding this comment.
What happened to the filter_condition parameter that I found in the docs?
Also I wish for the long line to be broken up (the horizontal scrolling makes me dizzy).
There was a problem hiding this comment.
Could you address @gvanrossum's comment?
Note that we have since changed the recommended line length to 130.
|
Annotating |
| read_capacity_to_consume_per_second: int = ..., | ||
| max_sleep_between_retry: int = ..., | ||
| max_consecutive_exceptions: int = ..., | ||
| **filters: Any |
There was a problem hiding this comment.
Looks like consistent_read and index_name are still missing?
There was a problem hiding this comment.
Oops, sorry for overlooking this.
| page_size: Optional[int] = ..., | ||
| timeout_seconds: Optional[int] = ..., | ||
| read_capacity_to_consume_per_second: int = ..., | ||
| allow_rate_limited_scan_without_consumed_capacity: Optional[bool]=None, |
There was a problem hiding this comment.
Defaults should always be ... (you'll get a lint error for this) and = should be surrounded by spaces if there's a type annotation.
The `rate_limited_scan` method has defaults for all arguments, including `attributes_to_get` which was omitted.
The
rate_limited_scanmethod has defaults for all arguments, includingattributes_to_getwhich was omitted.