Add stubs for tabulate #2384
Merged
Add stubs for tabulate #2384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you get permission from the author of this library, as required by typeshed's guidelines? |
srittau
requested changes
Nov 19, 2018
third_party/2and3/tabulate.pyi
Outdated
|
|
||
|
|
||
| def tabulate( | ||
| tabular_data: Sequence[Sequence[Any]], |
There was a problem hiding this comment.
This should be at least Iterable[Iterable[Any]]. It seems that tabulate supports a few more formats, so maybe Any would be better for the moment.
third_party/2and3/tabulate.pyi
Outdated
|
|
||
| def tabulate( | ||
| tabular_data: Sequence[Sequence[Any]], | ||
| headers: Sequence[str] = ..., |
There was a problem hiding this comment.
headers can also be a str or a Dict[str, str].
| # Stub for tabulate: https://bitbucket.org/astanin/python-tabulate | ||
| from typing import Any, Sequence | ||
|
|
||
|
|
There was a problem hiding this comment.
Since the stub is incomplete, please add the following at module level:
def __getattr__(name: str) -> Any: ...
gaul
commented
Dec 16, 2018
| # Stub for tabulate: https://bitbucket.org/astanin/python-tabulate | ||
| from typing import Any, Sequence | ||
|
|
||
|
|
third_party/2and3/tabulate.pyi
Outdated
|
|
||
|
|
||
| def tabulate( | ||
| tabular_data: Sequence[Sequence[Any]], |
third_party/2and3/tabulate.pyi
Outdated
|
|
||
| def tabulate( | ||
| tabular_data: Sequence[Sequence[Any]], | ||
| headers: Sequence[str] = ..., |
srittau
approved these changes
Dec 17, 2018
|
Thank you. Just for future reference: We prefer people not to force push, since this makes it harder for us to review changes. We squash commits anyway when we merge changes. |
yedpodtrzitko
pushed a commit
to yedpodtrzitko/typeshed
that referenced
this pull request
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.