Skip to content

os.path.exists (Py 3) accepts a file descriptor #2451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 24, 2018
Merged

os.path.exists (Py 3) accepts a file descriptor #2451

merged 2 commits into from
Sep 24, 2018

Conversation

srittau
Copy link
Collaborator

@srittau srittau commented Sep 12, 2018

Closes #1653

bluetech
bluetech approved these changes Sep 24, 2018
View reviewed changes
Copy link
Contributor

@bluetech bluetech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

BTW, the 2/ and 3/ files are the same; is there a reason it's not in 2and3/?

@JelleZijlstra
Copy link
Member

@bluetech it's not possible to have just os/path.pyi in 2and3; we need to merge os/__init__.pyi too. I started working towards that but haven't been able to finish the project yet.

@JelleZijlstra JelleZijlstra merged commit ea21227 into python:master Sep 24, 2018
@srittau srittau deleted the os-path-exists branch September 24, 2018 14:57
yedpodtrzitko pushed a commit to yedpodtrzitko/typeshed that referenced this pull request Jan 23, 2019
@srittau
os.path.exists (Py 3) accepts a file descriptor (python#2451)
62e0d39 
Closes python#1653
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluetech bluetech bluetech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srittau @JelleZijlstra @bluetech