Skip to content

Add six.moves.urllib_request and six.moves.urllib_response. #2455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2018
Merged

Conversation

rchen152
Copy link
Collaborator

Like the other six.moves.urllib.{foo} modules, request and response can be imported as six.moves.urllib_{foo}.

There's a mypy_selftest failure that I'm also seeing in a couple other recent PRs (e.g., #2433), so I don't think it's related to this change.

@srittau srittau mentioned this pull request Sep 13, 2018
Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I will merge this when the CI test failures are fixed. (See #2456)

@srittau srittau merged commit 77e4d5d into master Sep 13, 2018
@JelleZijlstra JelleZijlstra deleted the six branch September 13, 2018 20:02
yedpodtrzitko pushed a commit to yedpodtrzitko/typeshed that referenced this pull request Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants