Add missing instance attributes to logging.LoggerAdapter #2462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srittau
requested changes
Sep 18, 2018
Collaborator
srittau
left a comment
srittau
left a comment
There was a problem hiding this comment.
Thank you for the pull request. I left one comment below.
stdlib/2and3/logging/__init__.pyi
Outdated
|
|
||
| class LoggerAdapter: | ||
| logger = ... # type: Logger | ||
| extra = ... # type: Mapping[str, Any] |
Collaborator
There was a problem hiding this comment.
For new code we prefer PEP 526 variable annotation syntax, e.g.extra: Mapping[str, Any].
srittau
approved these changes
Sep 18, 2018
yedpodtrzitko
pushed a commit
to yedpodtrzitko/typeshed
that referenced
this pull request
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2350