Fix signatures of call, check_call and check_output in subprocess #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def call(args: Union[str, Sequence[str]], *, stdin: Any = ..., stdout: Any = ..., | ||
| stderr: Any = ..., shell: bool = ..., | ||
| # Same args as Popen.__init__ | ||
| def call(args: Union[str, Sequence[str]], |
There was a problem hiding this comment.
This new definition drops the fact that all arguments except for args are keyword-only.
(That's the right thing to do for 2.7/, but I'm guessing that for 3/ the '*' was actually justified)
There was a problem hiding this comment.
ah, didn't know about the new keyword-only-args feature -- but looks like the Popen in python3 isn't using it
| creationflags: int = ..., | ||
| restore_signals: bool = ..., | ||
| start_new_session: bool = ..., | ||
| pass_fds: Any = ...) -> bytes: ... |
There was a problem hiding this comment.
This shouldn't be bytes because check_output returns str when universal_newlines=True.
There was a problem hiding this comment.
ah, my bad, sorry -- will check for similar errors and send fix, unless you already have one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.