Add AIFC module stubs #3075
Merged
Add AIFC module stubs #3075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! Without doing a proper review yet, could you remove the empty lines between functions and inside class bodies? We prefer conciseness in typeshed, see our contribution guidelines. |
JelleZijlstra
requested changes
Jul 4, 2019
|
All requested changes have been made so far, ready for review again. |
srittau
reviewed
Sep 11, 2019
srittau
approved these changes
Sep 11, 2019
|
Just waiting for @JelleZijlstra's approval now. |
JelleZijlstra
approved these changes
Sep 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add type stubs for the AIFC module. Should be another checkbox for #1019 and #1147, presuming I have the types right.