Enable --disallow-any-generics for stubs #3288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srittau
commented
Oct 1, 2019
| @@ -105,8 +105,6 @@ class Popen(Generic[_T]): | |||
| def send_signal(self, signal: int) -> None: ... | |||
| def terminate(self) -> None: ... | |||
| def kill(self) -> None: ... | |||
| def __enter__(self) -> Popen: ... | |||
| def __exit__(self, type, value, traceback) -> None: ... | |||
There was a problem hiding this comment.
These are neither described in the documentation, nor could I find them in the implementation, and a short test also showed they don't exist at runtime.
JelleZijlstra
approved these changes
Oct 1, 2019
srittau
commented
Oct 1, 2019
| @@ -55,26 +55,26 @@ Boolean: Type[bool] | |||
| class DateTime: | |||
| value: str | |||
| def __init__(self, value: Union[str, unicode, datetime, float, int, _timeTuple, struct_time] = ...) -> None: ... | |||
| def make_comparable(self, other: _dateTimeComp) -> Tuple[_dateTimeComp, _dateTimeComp]: ... | |||
| def make_comparable(self, other: _dateTimeComp) -> Tuple[unicode, unicode]: ... | |||
There was a problem hiding this comment.
This could be tightened by using overloads for other.
srittau
commented
Oct 1, 2019
| @@ -12,7 +12,7 @@ from gzip import GzipFile | |||
| _Unmarshaller = Any | |||
| _timeTuple = Tuple[int, int, int, int, int, int, int, int, int] | |||
| # Represents types that can be compared against a DateTime object | |||
| _dateTimeComp = Union[AnyStr, DateTime, datetime, _timeTuple] | |||
There was a problem hiding this comment.
These methods also accept objects that have a timetuple attribute, but not a tuple itself. This could be solved using a protocol, but I'll leave that to someone else.
|
Great job! Thank you for all the fixes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As previously, most of these types could probably be tightened down.
Closes #3267