hashlib: fix arguments #3626
Merged
hashlib: fix arguments #3626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srittau
requested changes
Jan 21, 2020
stdlib/3/hashlib.pyi
Outdated
| def sha224(string: _DataType = ...) -> _Hash: ... | ||
| def sha256(string: _DataType = ...) -> _Hash: ... | ||
| def sha384(string: _DataType = ...) -> _Hash: ... | ||
| def sha512(string: _DataType = ...) -> _Hash: ... |
There was a problem hiding this comment.
I just tested this with Python 3.7.5:
>>> hashlib.md5(string="")
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
TypeError: openssl_md5() takes no keyword argumentsI suggest to mark them as positional-only arguments.
There was a problem hiding this comment.
Looks like it changed for py38:
>>> sys.version
'3.8.0 (default, Jan 3 2020, 22:27:51) \n[Clang 10.0.1 (clang-1001.0.46.4)]'
>>> hashlib.md5(string=b"")
<md5 HASH object @ 0x10f656b90>
I'll update the PR.
srittau
approved these changes
Jan 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scrypt, change types to Optional since default values are None